n-api: add more int64_t tests
#19402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
mhdawson
reviewed
Mar 20, 2018
src/node_api.cc
Outdated
| if (std::isnan(doubleValue)) { | ||
| *result = 0; | ||
| } else { | ||
| if (std::isfinite(doubleValue)) { |
There was a problem hiding this comment.
Can you update the comment above as well. It refers to NaN and the check no longer does. Would be good if the comment explained why the broader check makes sense.
There was a problem hiding this comment.
Yup, I forgot to do that.
|
@nodejs/n-api Can you please take a look? |
|
@mhdawson I also made some tweaks to the documentation, any other concerns about this change? There's a somewhat open issue about what we expect the API to do when the Number value exceeds the range of int64, but I'm not addressing that directly here other than to have a test for the current behavior. |
|
@nodejs/n-api Any thoughts on this PR? |
src/node_api.cc
Outdated
| // v8::Value::Int32Value() that converts NaN to 0. So special-case NaN here. | ||
| // v8::Value::IntegerValue() converts NaN, +Inf, and -Inf to INT64_MIN, | ||
| // inconsistent with v8::Value::Int32Value() which converts those values to 0. | ||
| // Special case all non-finite values match that behavior. |
There was a problem hiding this comment.
"... values [to] match that ... "
There was a problem hiding this comment.
... and perhaps "Special[-]case all ..."
kfarnung
force-pushed
the
napi_int64
branch
2 times, most recently
from
1b85199
to
c5953f1
Compare
|
I think a new CI is required at this point: https://ci.nodejs.org/job/node-test-pull-request/14061/ |
jasnell
approved these changes
Apr 4, 2018
|
It looks like the Linux failure was in doc generation: https://ci.nodejs.org/job/node-test-commit-linux/17645/nodes=ubuntu1204-64/console And FreeBSD 10 failed a test: https://ci.nodejs.org/job/node-test-commit-freebsd/16725/nodes=freebsd10-64/console |
kfarnung
added a commit
that referenced
this pull request
Apr 8, 2018
* Updated tests for `Number` and `int32_t` * Added new tests for `int64_t` * Updated N-API `int64_t` behavior to return zero for all non-finite numbers * Clarified the documentation for these calls. PR-URL: #19402 Refs: nodejs/node-chakracore#500 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in c529168 |
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 12, 2018
* Updated tests for `Number` and `int32_t` * Added new tests for `int64_t` * Updated N-API `int64_t` behavior to return zero for all non-finite numbers * Clarified the documentation for these calls. PR-URL: nodejs#19402 Refs: nodejs/node-chakracore#500 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2018
* Updated tests for `Number` and `int32_t` * Added new tests for `int64_t` * Updated N-API `int64_t` behavior to return zero for all non-finite numbers * Clarified the documentation for these calls. PR-URL: #19402 Refs: nodejs/node-chakracore#500 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed on |
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 16, 2018
* Updated tests for `Number` and `int32_t` * Added new tests for `int64_t` * Updated N-API `int64_t` behavior to return zero for all non-finite numbers * Clarified the documentation for these calls. PR-URL: nodejs#19402 Refs: nodejs/node-chakracore#500 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 16, 2018
* Updated tests for `Number` and `int32_t` * Added new tests for `int64_t` * Updated N-API `int64_t` behavior to return zero for all non-finite numbers * Clarified the documentation for these calls. Backport-PR-URL: #19447 PR-URL: #19402 Refs: nodejs/node-chakracore#500 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 1, 2018
* Updated tests for `Number` and `int32_t` * Added new tests for `int64_t` * Updated N-API `int64_t` behavior to return zero for all non-finite numbers * Clarified the documentation for these calls. Backport-PR-URL: #19265 PR-URL: #19402 Refs: nodejs/node-chakracore#500 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updated/added tests for
Numberandint32_tas well.Updated N-API int64 behavior to check for all non-finite numbers
instead of just NaN.
Ref: nodejs/node-chakracore#500
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes