test: move ESM fixtures to fixtures dir #19409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
added
the
esm
jasnell
approved these changes
Mar 17, 2018
guybedford
approved these changes
Mar 17, 2018
richardlau
reviewed
Mar 17, 2018
| @@ -4,6 +4,7 @@ const { execFileSync } = require('child_process'); | |||
|
|
|||
| const node = process.argv[0]; | |||
|
|
|||
| execFileSync(node, ['--experimental-modules', 'test/es-module/test-esm-ok']); | |||
| execFileSync(node, ['--experimental-modules', | |||
| 'test/fixtures/es-modules/test-esm-ok']); | |||
There was a problem hiding this comment.
Should this use the common.fixtures module?
cjihrig
approved these changes
Mar 19, 2018
devsnek
approved these changes
Mar 19, 2018
XadillaX
approved these changes
Mar 19, 2018
Also consistently import the `common` module where possible.
targos
force-pushed
the
test-esm-fixtures
branch
from
8a599b3
to
ecc6965
Compare
richardlau
approved these changes
Mar 21, 2018
|
Landed in fddcd62 |
targos
added a commit
that referenced
this pull request
Mar 21, 2018
Also consistently import the `common` module where possible. PR-URL: #19409 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also consistently import the
commonmodule where possible.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes