test: update assert messages to show expected and actual values #19420
Conversation
domahony
changed the title
| xxxxxxxxxx xxxxxxxxxx | ||
| xxxxxxxxxx xxxxxxxxxx` | ||
| tmpdir.refresh(); | ||
| fs.writeFileSync(filename, dataExpected); |
There was a problem hiding this comment.
Nit: Instead of creating the file in the tmpdir, maybe it would be better to put the file permanently in test/fixtures and read it from there?
There was a problem hiding this comment.
I agree. I'll make this change.
domahony
force-pushed
the
pr-fix-readfile-pipe-test
branch
from
1acb95a
to
97bd124
Compare
|
I amended the commit because the node-test-linter test failed. |
|
Agreed that AIX failure seems unrelated. Let's run again to get a clean lint run and see if AIX is building OK now. |
|
AIX failed again but I think I fixed the build problem. One more time on AIX only: https://ci.nodejs.org/job/node-test-commit-aix/13420/ |
domahony
force-pushed
the
pr-fix-readfile-pipe-test
branch
from
97bd124
to
104ff10
Compare
uses the same approach as in test-fs-readfile-pipe-large
The test originally used the contents of the test file as test data. However, if the assertion fires, the resulting message is difficult to comprehend. The test now uses a short string of regularly formatted x characters that make it easier to spot differences in the expected and actual values.
The test originally used the contents of the test file as test data. However, if the assertion fires, the resulting message is difficult to comprehend. The test now uses a short string of regularly formatted x characters that make it easier to spot differences in the expected and actual values.
The test has been updated to read a test file from the test/fixtures folder. This makes the source of the test less cluttered.
domahony
force-pushed
the
pr-fix-readfile-pipe-test
branch
from
104ff10
to
cfb0cc3
Compare
|
Hmmm...looks like the AIX results have expired. OK, let's try this again: |
Trott
added
the
author ready
|
Re-running ARM: https://ci.nodejs.org/job/node-test-commit-arm/15117/ |
uses the same approach as in test-fs-readfile-pipe-large PR-URL: #19420 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
uses the same approach as in test-fs-readfile-pipe-large PR-URL: #19420 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
The test-fs-readfile-pipe unit test has been updated to display the actual and expected values when the assertion fires. The test has also been updated to use a string of regularly formatted x characters as test data so that differences between the actual and expected values are easier to spot.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes