Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf_hooks,trace_events: fix timescale on bootstrap marks #19450

Closed
wants to merge 1 commit into from
Closed

perf_hooks,trace_events: fix timescale on bootstrap marks #19450

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Mar 19, 2018

/cc @addaleax

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines]

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 19, 2018
@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 19, 2018
@jasnell
Copy link
Member Author

jasnell commented Mar 19, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13741/

jasnell added a commit that referenced this pull request Mar 20, 2018
@jasnell
perf_hooks,trace_events: fix timescale on bootstrap marks
1f356a2 
PR-URL: #19450
Reviewed-By: Anna Henningsen <[email protected]>
@jasnell
Copy link
Member Author

jasnell commented Mar 20, 2018

Landed in 1f356a2

@jasnell jasnell closed this Mar 20, 2018
@MylesBorins
Copy link
Contributor

Should this be backported to v9.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasnell @MylesBorins @addaleax @nodejs-github-bot