Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix assert.throws error in test-http-parser #19626

Closed
wants to merge 1 commit into from
Closed

test: fix assert.throws error in test-http-parser #19626

wants to merge 1 commit into from

Commits on Mar 27, 2018

  1. test: fix assert.throws error in test-http-parser 

    The third argument of `assert.throws()` is a message that is used by the
AssertionError, not the message to check in the thrown error. It appears
that there is an assert.throws() in test-http-parser that expects the
latter behavior. Rewrite the call to check the error message. Even if
this wasn't a mistake, this change results in a more robust check.
    @Trott
    Trott committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    6197c5e View commit details
    Browse the repository at this point in the history