Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: resolve process.setgid error for group 'nobody' on ubuntu #19755

Closed
wants to merge 2 commits into from
Closed

test: resolve process.setgid error for group 'nobody' on ubuntu #19755

wants to merge 2 commits into from

Commits on Apr 10, 2018

  1. test: resolve process.setgid error for group 'nobody' on ubuntu 

    When the tests are run as root in Ubuntu, process.setgid is called with
'nobody' as an argument. This throws an error in Ubuntu. This is because
in Ubuntu the equivalent of 'nobody' group is named as 'nogroup'

This commit sets gid to 'nobody' first and if it throws a `group id does
not exist` error, it attempts to set gid to 'nogroup'. If it still
causes an error, the error is thrown.

Refs: nodejs#19594
    @dsinecos
    dsinecos committed Apr 10, 2018
    Configuration menu
    Copy the full SHA
    9e4b0dd View commit details
    Browse the repository at this point in the history

  2. test: remove else block 

    Else block removed as the `throw` in the preceding block makes it
redundant

Refs: nodejs#19594
    @dsinecos
    dsinecos committed Apr 10, 2018
    Configuration menu
    Copy the full SHA
    2129edf View commit details
    Browse the repository at this point in the history