Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update AUTHORS list #19768

Closed
wants to merge 3 commits into from
Closed

doc: update AUTHORS list #19768

wants to merge 3 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Apr 3, 2018

No description provided.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 3, 2018
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some entries the corresponding name of the person can be found in their github profile. Should we always use that name?

AUTHORS Outdated
Ujjwal Sharma <[email protected]>
Wei-Wei Wu <[email protected]>
punteek <[email protected]>
Tobias Nießen <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entry should be reflected in the mailmap.

AUTHORS Outdated
Tobias Nießen <[email protected]>
Ken Lin <[email protected]>
Piotr Grzesik <[email protected]>
feugy <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name is "Damien Feugas" and should be reflected as such (he has a middle name but I guess that is not important?).

@targos
Copy link
Member Author

targos commented Apr 3, 2018

Updated with names found in github profiles

Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -3,6 +3,8 @@ Aaron Heckmann <[email protected]> <[email protected]>
Aayush Ahuja <[email protected]> aayush.a <[email protected]>
Abe Fettig <[email protected]> <[email protected]>
Akito Ito <[email protected]> <[email protected]>
Alejandro Estrada <[email protected]>
Alejandro Estrada <[email protected]> <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has to be like that AFAICT. First entry for the name (it is lowercase in the commit log). Second entry for the email alias.

@targos targos mentioned this pull request Apr 5, 2018
@targos
Copy link
Member Author

targos commented Apr 5, 2018

targos added a commit to targos/node that referenced this pull request Apr 6, 2018
PR-URL: nodejs#19768
Reviewed-By: Ruben Bridgewater <[email protected]>
@targos
Copy link
Member Author

targos commented Apr 6, 2018

Landed in dca09a7

@targos targos closed this Apr 6, 2018
@targos targos deleted the update-authors branch April 6, 2018 07:07
targos added a commit that referenced this pull request Apr 6, 2018
PR-URL: #19768
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants