Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errors: fix typo in internal/errors.js #19800

Closed
wants to merge 1 commit into from
Closed

errors: fix typo in internal/errors.js #19800

wants to merge 1 commit into from

Conversation

davidmarkclements
Copy link
Member

corrects "eqaul" to "equal" in the description
for the ERR_NAPI_INVALID_DATAVIEW_ARGS error message

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines]

errors: fix typo in internal/errors.js
d77daad 
corrects "eqaul" to "equal" in the description
for the ERR_NAPI_INVALID_DATAVIEW_ARGS error message
@nodejs-github-bot nodejs-github-bot added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Apr 4, 2018
@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 4, 2018
@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/427/

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Apr 4, 2018 •
edited
Loading

Not sure if the full CI is needed. It seems no tests check this message literally:

https://github.com/nodejs/node/search?utf8=%E2%9C%93&q=eqaul&type=

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 4, 2018
@lpinca
Copy link
Member

lpinca commented Apr 6, 2018

Landed in f8b3774.

@lpinca lpinca closed this Apr 6, 2018
lpinca pushed a commit that referenced this pull request Apr 6, 2018
@lpinca
errors: fix typo in internal/errors.js
f8b3774 
Corrects "eqaul" to "equal" in the description for the
ERR_NAPI_INVALID_DATAVIEW_ARGS error message.

PR-URL: #19800
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Apr 12, 2018
@targos
errors: fix typo in internal/errors.js
9603c4a 
Corrects "eqaul" to "equal" in the description for the
ERR_NAPI_INVALID_DATAVIEW_ARGS error message.

PR-URL: #19800
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. errors Issues and PRs related to JavaScript errors originated in Node.js core. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@davidmarkclements @vsemozhetbyt @lpinca @jasnell @targos @cjihrig @tniessen @BridgeAR @trivikr @nodejs-github-bot