Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: move mafintosh to Collaborators #19806

Closed
wants to merge 1 commit into from
Closed

doc: move mafintosh to Collaborators #19806

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 4, 2018

mafintosh was accidentally added to the TSC list rather than the
Collaborators list. This corrects that.

Checklist

@Trott
doc: move mafintosh to Collaborators
aba3fa5 
mafintosh was accidentally added to the TSC list rather than the
Collaborators list. This corrects that.
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 4, 2018
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 4, 2018
@Trott
Copy link
Member Author

Trott commented Apr 4, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/426/

BridgeAR
BridgeAR approved these changes Apr 4, 2018
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

cjihrig
cjihrig approved these changes Apr 4, 2018
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking self nomination to a new level.

Trott added a commit to Trott/io.js that referenced this pull request Apr 4, 2018
@Trott
doc: move mafintosh to Collaborators
acc328e 
mafintosh was accidentally added to the TSC list rather than the
Collaborators list. This corrects that.

PR-URL: nodejs#19806
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@Trott
Copy link
Member Author

Trott commented Apr 4, 2018

Landed in acc328e

@Trott Trott closed this Apr 4, 2018
targos pushed a commit that referenced this pull request Apr 6, 2018
@Trott @targos
doc: move mafintosh to Collaborators
8adae8f 
mafintosh was accidentally added to the TSC list rather than the
Collaborators list. This corrects that.

PR-URL: #19806
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@Trott Trott deleted the not-tsc branch January 13, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @addaleax @targos @cjihrig @BridgeAR @nodejs-github-bot