Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve prepositions in buffer.md #19817

Closed
wants to merge 1 commit into from
Closed

doc: improve prepositions in buffer.md #19817

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 5, 2018 •
edited
Loading

  • at which to begin copying to -> at which to begin writing
  • at which to begin copying from -> from which to begin copying
  • wrap at 80 chars
Checklist

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Apr 5, 2018
@Trott
doc: improve prepositions in buffer.md
4c5afad 
* `at which to begin copying to` -> `at which to begin writing`
* `at which to begin copying from` -> `from which to begin copying`
* wrap at 80 chars
@Trott
Copy link
Member Author

Trott commented Apr 5, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/430/

@lpinca lpinca added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 5, 2018
@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 5, 2018
Trott added a commit to Trott/io.js that referenced this pull request Apr 6, 2018
@Trott
doc: improve prepositions in buffer.md
6179467 
* `at which to begin copying to` -> `at which to begin writing`
* `at which to begin copying from` -> `from which to begin copying`
* wrap at 80 chars

PR-URL: nodejs#19817
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott
Copy link
Member Author

Trott commented Apr 6, 2018

Landed in 6179467

@Trott Trott closed this Apr 6, 2018
targos pushed a commit that referenced this pull request Apr 6, 2018
@Trott @targos
doc: improve prepositions in buffer.md
09090e7 
* `at which to begin copying to` -> `at which to begin writing`
* `at which to begin copying from` -> `from which to begin copying`
* wrap at 80 chars

PR-URL: #19817
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott Trott deleted the from branch January 13, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @jasnell @lpinca @vsemozhetbyt @trivikr @nodejs-github-bot