Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve buf.fill() documentation #19846

Closed
wants to merge 1 commit into from
Closed

doc: improve buf.fill() documentation #19846

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 6, 2018

  • Improve prepositions.
  • Wrap at 80 characters.
  • Formalize colloquial text.
  • Remove unnecessary sentence.
  • Use colons to introduce example code.
Checklist

@Trott
doc: improve buf.fill() documentation
6dd3236 
* Improve prepositions.
* Wrap at 80 characters.
* Formalize colloquial text.
* Remove unnecessary sentence.
* Use colons to introduce example code.
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Apr 6, 2018
@Trott
Copy link
Member Author

Trott commented Apr 6, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/439/

@BridgeAR BridgeAR added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 6, 2018
@Trott
Copy link
Member Author

Trott commented Apr 7, 2018

Landed in 4545cc1

@Trott Trott closed this Apr 7, 2018
Trott added a commit to Trott/io.js that referenced this pull request Apr 7, 2018
@Trott
doc: improve buf.fill() documentation
4545cc1 
* Improve prepositions.
* Wrap at 80 characters.
* Formalize colloquial text.
* Remove unnecessary sentence.
* Use colons to introduce example code.

PR-URL: nodejs#19846
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Apr 12, 2018
@Trott @targos
doc: improve buf.fill() documentation
9a6333d 
* Improve prepositions.
* Wrap at 80 characters.
* Formalize colloquial text.
* Remove unnecessary sentence.
* Use colons to introduce example code.

PR-URL: #19846
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott Trott deleted the buf-fill branch January 13, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbev danbev danbev approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @danbev @jasnell @lpinca @cjihrig @BethGriggs @BridgeAR @nodejs-github-bot