Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: mention CCM along with GCM in crypto APIs #19945

Closed
wants to merge 1 commit into from
Closed

doc: mention CCM along with GCM in crypto APIs #19945

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

Some API descriptions need to be updated after landing #18138.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Apr 11, 2018
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 11, 2018
@BridgeAR
Copy link
Member

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite/486/

@vsemozhetbyt
Copy link
Contributor

New CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/488/

@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 12, 2018
@tniessen tniessen removed the fast-track PRs that do not need to wait for 48 hours to land. label Apr 13, 2018
@tniessen
Copy link
Member Author

Landed in 04148b1.

@tniessen tniessen closed this Apr 13, 2018
tniessen added a commit that referenced this pull request Apr 13, 2018
@tniessen
doc: mention CCM along with GCM in crypto APIs
04148b1 
PR-URL: #19945
Refs: #18138
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
jasnell pushed a commit that referenced this pull request Apr 16, 2018
@tniessen @jasnell
doc: mention CCM along with GCM in crypto APIs
0d1b77e 
PR-URL: #19945
Refs: #18138
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@tniessen tniessen removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tniessen @BridgeAR @vsemozhetbyt @jasnell @trivikr @nodejs-github-bot