Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix punctuation and wrapping in buffer.md #19964

Closed
wants to merge 1 commit into from
Closed

doc: fix punctuation and wrapping in buffer.md #19964

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 12, 2018

Remove unnecessary colons and wrap lines at 80 characters.

Checklist

@Trott
doc: fix punctuation and wrapping in buffer.md
a4abf47 
Remove unnecessary colons and wrap lines at 80 characters.
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Apr 12, 2018
@Trott
Copy link
Member Author

Trott commented Apr 12, 2018

@nodejs/documentation

@Trott
Copy link
Member Author

Trott commented Apr 12, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/500/

@Trott
Copy link
Member Author

Trott commented Apr 12, 2018

CI Lite again: https://ci.nodejs.org/job/node-test-pull-request-lite/501/

@vsemozhetbyt vsemozhetbyt added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 12, 2018
@BridgeAR
Copy link
Member

Landed in 0815555 🎉

@BridgeAR BridgeAR closed this Apr 12, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Apr 12, 2018
@Trott @BridgeAR
doc: fix punctuation and wrapping in buffer.md
0815555 
Remove unnecessary colons and wrap lines at 80 characters.

PR-URL: nodejs#19964
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
jasnell pushed a commit that referenced this pull request Apr 16, 2018
@Trott @jasnell
doc: fix punctuation and wrapping in buffer.md
90fc496 
Remove unnecessary colons and wrap lines at 80 characters.

PR-URL: #19964
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 1, 2018
@Trott @BridgeAR
doc: fix punctuation and wrapping in buffer.md
941919e 
Remove unnecessary colons and wrap lines at 80 characters.

PR-URL: nodejs#19964
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@Trott Trott deleted the satisfy branch January 13, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@gibfahn gibfahn gibfahn approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @BridgeAR @benjamingr @vsemozhetbyt @gibfahn @trivikr @nodejs-github-bot