Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[reland] deps: cherry-pick b767cde1e7 from upstream V8 #19980

Closed
wants to merge 1 commit into from
Closed

[reland] deps: cherry-pick b767cde1e7 from upstream V8 #19980

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Apr 12, 2018

This is a cherry pick of #19710 that we missed to re-apply in the V8 6.6 update

/cc @nodejs/v8-update

@bnoordhuis @targos
deps: cherry-pick b767cde1e7 from upstream V8
602ea95 
Original commit message:

    [intl] unbreak build with ICU 57

    Remove a call to `icu::toUCharPtr()` that wasn't present in other
    similar looking call sites either, just reinterpret_cast directly.

    Fixes nodejs#19656.

    Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
    Change-Id: If281ce0a39356aa8bd20efb24c3e4b52b06841a3
    Reviewed-on: https://chromium-review.googlesource.com/987953
    Reviewed-by: Daniel Ehrenberg <[email protected]>
    Commit-Queue: Ben Noordhuis <[email protected]>
    Cr-Commit-Position: refs/heads/master@{nodejs#52311}

PR-URL: nodejs#19710
Fixes: nodejs#19656
Refs: v8/v8@b767cde
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. labels Apr 12, 2018
@targos
Copy link
Member Author

targos commented Apr 13, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/14240/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1320/

jasnell pushed a commit that referenced this pull request Apr 14, 2018
@bnoordhuis @jasnell
deps: cherry-pick b767cde1e7 from upstream V8
45f6dcc 
Original commit message:

    [intl] unbreak build with ICU 57

    Remove a call to `icu::toUCharPtr()` that wasn't present in other
    similar looking call sites either, just reinterpret_cast directly.

    Fixes #19656.

    Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
    Change-Id: If281ce0a39356aa8bd20efb24c3e4b52b06841a3
    Reviewed-on: https://chromium-review.googlesource.com/987953
    Reviewed-by: Daniel Ehrenberg <[email protected]>
    Commit-Queue: Ben Noordhuis <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#52311}

PR-URL: #19710
Fixes: #19656
Refs: v8/v8@b767cde
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: James M Snell <[email protected]>

PR-URL: #19980
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Yang Guo <[email protected]>
@jasnell
Copy link
Member

jasnell commented Apr 14, 2018

Landed in 45f6dcc

@jasnell jasnell closed this Apr 14, 2018
jasnell pushed a commit that referenced this pull request Apr 16, 2018
@bnoordhuis @jasnell
deps: cherry-pick b767cde1e7 from upstream V8
b6aec1d 
Original commit message:

    [intl] unbreak build with ICU 57

    Remove a call to `icu::toUCharPtr()` that wasn't present in other
    similar looking call sites either, just reinterpret_cast directly.

    Fixes #19656.

    Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
    Change-Id: If281ce0a39356aa8bd20efb24c3e4b52b06841a3
    Reviewed-on: https://chromium-review.googlesource.com/987953
    Reviewed-by: Daniel Ehrenberg <[email protected]>
    Commit-Queue: Ben Noordhuis <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#52311}

PR-URL: #19710
Fixes: #19656
Refs: v8/v8@b767cde
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: James M Snell <[email protected]>

PR-URL: #19980
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Yang Guo <[email protected]>
@targos targos deleted the reland-v8-patch branch October 17, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@hashseed hashseed hashseed approved these changes

@jasnell jasnell jasnell approved these changes

@ofrobots ofrobots ofrobots approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@targos @jasnell @ofrobots @hashseed @cjihrig @nodejs-github-bot @bnoordhuis