-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
errors: alter and test ERR_INVALID_REPL_EVAL_CONFIG #19984
Conversation
changes the base instance for ERR_INVALID_REPL_EVAL_CONFIG from Error to TypeError as a more accurate representation of the error and adds a unit test for the repl options that trigger this error.
CI failure is unrelated. @nodejs/tsc .. any objections to this landing in 10.0.0? |
changes the base instance for ERR_INVALID_REPL_EVAL_CONFIG from Error to TypeError as a more accurate representation of the error and adds a unit test for the repl options that trigger this error. PR-URL: #19984 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Landed in 8826cc9 |
This landed in violation of several of our rules.
On the one hand, I'm inclined to cut @jasnell a ton of slack as he's on a PR-landing spree right now, probably in preparation for 10.0. On the other hand, though, I'm kind of worried about the example this sort of thing sets for other Collaborators. |
Think I missed this one up with another very similar one. And yes, I'm preparing for a big update for 10.0.0 on Monday so trying to get things that can land landed. My apologies for the oversight on this one |
Ah well, just one more data point in favor of ever increased automation. :-D |
changes the base instance for ERR_INVALID_REPL_EVAL_CONFIG from Error to TypeError as a more accurate representation of the error and adds a unit test for the repl options that trigger this error. PR-URL: #19984 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
changes the base instance for ERR_INVALID_REPL_EVAL_CONFIG
from Error to TypeError as a more accurate representation
of the error and adds a unit test for the repl options that
trigger this error.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes