Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors: alter and test ERR_INVALID_REPL_EVAL_CONFIG #19984

Closed
wants to merge 1 commit into from
Closed

errors: alter and test ERR_INVALID_REPL_EVAL_CONFIG #19984

wants to merge 1 commit into from

Conversation

davidmarkclements
Copy link
Member

changes the base instance for ERR_INVALID_REPL_EVAL_CONFIG
from Error to TypeError as a more accurate representation
of the error and adds a unit test for the repl options that
trigger this error.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

changes the base instance for ERR_INVALID_REPL_EVAL_CONFIG
from Error to TypeError as a more accurate representation
of the error and adds a unit test for the repl options that
trigger this error.
@nodejs-github-bot nodejs-github-bot added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Apr 12, 2018
@BridgeAR BridgeAR added the semver-major PRs that contain breaking changes and should be released in the next major version. label Apr 13, 2018
@BridgeAR BridgeAR requested a review from a team April 13, 2018 19:21
@BridgeAR
Copy link
Member

@jasnell
Copy link
Member

jasnell commented Apr 14, 2018

CI failure is unrelated.

@nodejs/tsc .. any objections to this landing in 10.0.0?

jasnell pushed a commit that referenced this pull request Apr 14, 2018
changes the base instance for ERR_INVALID_REPL_EVAL_CONFIG
from Error to TypeError as a more accurate representation
of the error and adds a unit test for the repl options that
trigger this error.

PR-URL: #19984
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@jasnell
Copy link
Member

jasnell commented Apr 14, 2018

Landed in 8826cc9

@jasnell jasnell closed this Apr 14, 2018
@Trott
Copy link
Member

Trott commented Apr 14, 2018

This landed in violation of several of our rules.

On the one hand, I'm inclined to cut @jasnell a ton of slack as he's on a PR-landing spree right now, probably in preparation for 10.0. On the other hand, though, I'm kind of worried about the example this sort of thing sets for other Collaborators.

@jasnell
Copy link
Member

jasnell commented Apr 14, 2018

Think I missed this one up with another very similar one. And yes, I'm preparing for a big update for 10.0.0 on Monday so trying to get things that can land landed. My apologies for the oversight on this one

@Trott
Copy link
Member

Trott commented Apr 15, 2018

Ah well, just one more data point in favor of ever increased automation. :-D

jasnell pushed a commit that referenced this pull request Apr 16, 2018
changes the base instance for ERR_INVALID_REPL_EVAL_CONFIG
from Error to TypeError as a more accurate representation
of the error and adds a unit test for the repl options that
trigger this error.

PR-URL: #19984
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
errors Issues and PRs related to JavaScript errors originated in Node.js core. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants