lib: use object destructuring for canonicalizeIP #20070
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates canonicalizeIP to use object destructuring which is done for other functions in lib/tls.js
tniessen
approved these changes
Apr 16, 2018
addaleax
approved these changes
Apr 16, 2018
lpinca
approved these changes
Apr 16, 2018
lpinca
added
the
author ready
cjihrig
approved these changes
Apr 16, 2018
BridgeAR
approved these changes
Apr 16, 2018
lib/tls.js
Outdated
| @@ -33,7 +33,7 @@ const binding = process.binding('crypto'); | |||
| const Buffer = require('buffer').Buffer; | |||
There was a problem hiding this comment.
This should also use destructuring.
There was a problem hiding this comment.
Thanks, I missed that one. I'll update shortly.
jasnell
approved these changes
Apr 16, 2018
trivikr
approved these changes
Apr 18, 2018
lpinca
approved these changes
Apr 18, 2018
trivikr
approved these changes
Apr 18, 2018
node-test-commit failure looks unrelated06:36:40 not ok 2170 es-module/test-esm-preserve-symlinks-not-found
06:36:40 ---
06:36:40 duration_ms: 0.264
06:36:40 severity: crashed
06:36:40 exitcode: -6
06:36:40 stack: |-
06:36:40 oh no!
06:36:40 exit code: CRASHED (Signal: 6)
06:36:40 ... |
|
Landed in 72d1586. |
danbev
added a commit
that referenced
this pull request
Apr 19, 2018
This commit updates canonicalizeIP and Buffer to use object destructuring which is done for other functions in lib/tls.js PR-URL: #20070 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Apr 19, 2018
This commit updates canonicalizeIP and Buffer to use object destructuring which is done for other functions in lib/tls.js PR-URL: #20070 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates canonicalizeIP to use object destructuring which is
done for other functions in lib/tls.js
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes