Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: normalise test.py calls to use PARALLEL_ARGS #20124

Closed
wants to merge 1 commit into from
Closed

build: normalise test.py calls to use PARALLEL_ARGS #20124

wants to merge 1 commit into from

Conversation

chrismilleruk
Copy link
Contributor

All calls to test.py from Makefile now explicitly read the JOBS env var and passes -j X otherwise falls back to the -J flag.

Fixes: #20065

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Apr 18, 2018
@Trott
Copy link
Member

Trott commented Apr 18, 2018

@nodejs/build

addaleax
addaleax approved these changes Apr 20, 2018
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and in particular +1 to doing this

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 22, 2018
@BridgeAR
Copy link
Member

I guess we do not have to run a CI here.

@chrismilleruk
Copy link
Contributor Author

I’d probably err the other way if it’s easy enough.

If there is an environment/situation where the parallel flags cause problems it would be good to discover it early.

@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/14424/

@BridgeAR
Copy link
Member

Landed in 8786889 🎉

@BridgeAR BridgeAR closed this Apr 23, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Apr 23, 2018
@chrismilleruk @BridgeAR
build: normalise test.py calls to use PARALLEL_ARGS
8786889 
PR-URL: nodejs#20124
Fixes: nodejs#20065
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
jasnell pushed a commit that referenced this pull request Apr 23, 2018
@chrismilleruk @jasnell
build: normalise test.py calls to use PARALLEL_ARGS
a4cba2d 
PR-URL: #20124
Fixes: #20065
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build: Improve consistency of parallelism flags among make->python dependencies
7 participants
@chrismilleruk @Trott @BridgeAR @addaleax @joyeecheung @richardlau @nodejs-github-bot