Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspector: migrate node to js_protocol.pdl #20141

Closed
wants to merge 1 commit into from
Closed

inspector: migrate node to js_protocol.pdl #20141

wants to merge 1 commit into from

Conversation

alexkozy
Copy link
Member

On inspector side we are going to deprecate .json protocol
definition format and replace it with new .pdl format.
New format allows us to use multiline commends and contains less
noise in comparision then .json.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Apr 19, 2018
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. CI: https://ci.nodejs.org/job/node-test-pull-request/14380/

The .pdl file (pronounced "poodle"?) is a lot more readable too.

Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM but is there documentation for the PDL format?

On inspector side we are going to deprecate .json protocol
definition formation and replace it with new .pdl format.
New format allows us to use multiline commends and contains less
noise in comparision then .json.
@alexkozy
Copy link
Member Author

Unfortunately we do not have dedicated doc about .pdl but we believe that it is self explained and some basic format parser may be found in our ConverProtocolToJSON.py script. I think that we will add some doc later.

@pavelfeldman , is poodle right pronunciation? :)

To fix CI I introduced temporary action which copies .pdl file to shared_intermediate_folder, this action will gone after one of the next V8 roll.

@jasnell
Copy link
Member

jasnell commented Apr 19, 2018

Ok, would definitely prefer to have documentation for the format sooner than later :-)

alexkozy added a commit that referenced this pull request Apr 20, 2018
On inspector side we are going to deprecate .json protocol
definition formation and replace it with new .pdl format.
New format allows us to use multiline commends and contains less
noise in comparision then .json.

PR-URL: #20141
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@alexkozy
Copy link
Member Author

Landed in fda2b9a

@alexkozy alexkozy closed this Apr 20, 2018
@alexkozy alexkozy deleted the migrate-node-to-pdl branch April 20, 2018 14:52
@alexkozy alexkozy restored the migrate-node-to-pdl branch April 20, 2018 14:52
@joyeecheung
Copy link
Member

The passing CI didn't get posted: https://ci.nodejs.org/job/node-test-pull-request/14388/

@alexkozy
Copy link
Member Author

alexkozy commented Apr 20, 2018

Thanks for posting a link!
Failure on OS X looks unrelated and not reproducible on local Mac build. I rerun CI to be sure that everything is ok.

jasnell pushed a commit that referenced this pull request Apr 20, 2018
On inspector side we are going to deprecate .json protocol
definition formation and replace it with new .pdl format.
New format allows us to use multiline commends and contains less
noise in comparision then .json.

PR-URL: #20141
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
hashseed pushed a commit to v8/node that referenced this pull request Apr 23, 2018
On inspector side we are going to deprecate .json protocol
definition formation and replace it with new .pdl format.
New format allows us to use multiline commends and contains less
noise in comparision then .json.

PR-URL: nodejs#20141
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
On inspector side we are going to deprecate .json protocol
definition formation and replace it with new .pdl format.
New format allows us to use multiline commends and contains less
noise in comparision then .json.

PR-URL: nodejs#20141
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants