Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky child-process-exec-kill-throws #20213

Closed
wants to merge 1 commit into from
Closed

test: fix flaky child-process-exec-kill-throws #20213

wants to merge 1 commit into from

Conversation

santigimeno
Copy link
Member

Kill the child process with SIGKILL to make sure the child process
does not remain alive.

Fixes: #20139

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@santigimeno
test: fix flaky child-process-exec-kill-throws
96fe017 
Kill the child process with `SIGKILL` to make sure the child process
does not remain alive.

Fixes: nodejs#20139
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 22, 2018
@santigimeno
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/14428/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 23, 2018
@trivikr
Copy link
Member

trivikr commented Apr 26, 2018

Landed in f1d9527

@trivikr trivikr closed this Apr 26, 2018
trivikr pushed a commit that referenced this pull request Apr 26, 2018
@santigimeno @trivikr
test: fix flaky child-process-exec-kill-throws
f1d9527 
Kill the child process with `SIGKILL` to make sure the child process
does not remain alive.

Fixes: #20139

PR-URL: #20213
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 4, 2018
@santigimeno @MylesBorins
test: fix flaky child-process-exec-kill-throws
769b6c8 
Kill the child process with `SIGKILL` to make sure the child process
does not remain alive.

Fixes: #20139

PR-URL: #20213
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@starkwang starkwang starkwang approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test-child-process-exec-kill-throws fails intermittently on multiple platforms
7 participants
@santigimeno @trivikr @jasnell @Trott @lpinca @starkwang @nodejs-github-bot