doc, lib, test, tools: eliminate quote escaping

[vsemozhetbyt]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• documentation is changed or added
• commit message follows commit guidelines

Currently, we have ESLint rule that allows using double quotes to reduce escaping of single quotes inside strings.

However, we have some flaws in this domain:

• This possibility is not fully utilized in our code.
• The ESLint rule does not suffice for cases when both single and double quotes are used inside strings.

This PR tries to fix both:

• The ESLint rule is expanded to allow backticks, to reduce escaping in strings with both single and double quotes inside.
• Most of the current escaping cases are eliminated.

It seems this change improves readability and sometimes reduces string concatenating due to a shorter length of fixed strings.

Refs: https://eslint.org/docs/rules/quotes

[vsemozhetbyt]

CI-lite: https://ci.nodejs.org/job/node-test-pull-request/14429/

[vsemozhetbyt]

It seems this should only be backported to v10 (easy) and v8 (not so hard): v6 is almost on maintenance and v9 will be EOL soon. I can do both backportings then (proactively if requested).

[devsnek]

this seems pretty large and i think escaping looks better, its probably fine how it is?

[vsemozhetbyt]

Let's see what others think, we can easily close this)

[devsnek]

@nodejs/linting

[not-an-aardvark]

¯\_(ツ)_/¯ I have no strong feelings either way.

[Trott]

Not a strong feeling, but I tend to side with @devsnek that this is a fair amount of churn that doesn't seem to substantially improve the code. But if others feel differently, I'm fine with it. I would ask that if you intend to land it on master soon, that you open backport PRs right away because it seems highly likely it will not cleanly cherry-pick to the staging branches.

[Trott]

Actually, upon further review, I'm a little concerned by allowTemplateLiterals. In the past (before linting prevented it), I believe there had been nits about using backticks unnecessarily and I don't want to see those return if our linter becomes more lenient than our reviewers. I might be -1 on this after all....

[Trott]

Yeah, sorry, but I gotta -1 this, at least as long as allowTemplateLiterals is in there. With this change, this becomes acceptable to the linter:

var http = require(`http`);  // using backticks instead of single quotes!

I imagine I'm not the only one that wouldn't want to make the linter more lenient that way.

[vsemozhetbyt]

Ok, I will close due to doubts and concerns)

[BridgeAR]

@vsemozhetbyt when looking at these changes, it feels like 95% were not about using backticks and just improved the situation by switching to double quotes instead of having escaped single quotes in single quotes.

[vsemozhetbyt]

@BridgeAR Yeah, but there were also shared concerns if this actually makes the code better, and I do not want to make collaborators disturbed over heavy nits without obvious improvements)