src: remove SecureContext _external getter
#20237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is unused inside Node core, so nothing good can come from keeping it around.
nodejs-github-bot
added
c++
|
CITGM run? |
danbev
approved these changes
Apr 24, 2018
bnoordhuis
approved these changes
Apr 24, 2018
BridgeAR
approved these changes
Apr 24, 2018
BridgeAR
added
the
author ready
cjihrig
approved these changes
Apr 24, 2018
jasnell
approved these changes
Apr 24, 2018
TimothyGu
approved these changes
Apr 24, 2018
tniessen
approved these changes
Apr 25, 2018
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Apr 26, 2018
This is unused inside Node core, so nothing good can come from keeping it around. PR-URL: nodejs#20237 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
|
Landed in 03e25b6 🎉 |
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
This is unused inside Node core, so nothing good can come from keeping it around. PR-URL: #20237 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
|
This broke uWebsockets bindings for nodejs: https://github.com/uNetworking/uWebSockets-bindings/blob/master/nodejs/src/uws.js#L508 |
|
@dyatlov That library is messing with Node’s internals in multiple ways that are very sensitive to changes… reverting this might work as a short-term measure (and you can feel free to open a PR if you like), but: Do not expect that library to be usable in a stable way, there are many ways in which it could break unexpectedly. This is a larger issue that the library authors need to address – this might require opening a few issues here, but it should be worth the effort. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is unused inside Node core, so nothing good can come from keeping it around.
(If somebody wants to label this
semver-major, I don’t really care, but it’s really just unused code in an internal API that can’t really be used in a meaningful way.)Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes