Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timers: named anonymous functions #20397

Closed
wants to merge 1 commit into from
Closed

timers: named anonymous functions #20397

wants to merge 1 commit into from

Conversation

js-kyle
Copy link
Contributor

@js-kyle js-kyle commented Apr 29, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Ref: #8913

@nodejs-github-bot nodejs-github-bot added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Apr 29, 2018
apapirovski
apapirovski approved these changes Apr 29, 2018
View reviewed changes
Copy link
Member

@apapirovski apapirovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @js-kyle!

@apapirovski
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/14575/

@BridgeAR BridgeAR added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 29, 2018
benjamingr
benjamingr approved these changes Apr 29, 2018
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

trivikr pushed a commit that referenced this pull request May 3, 2018
@js-kyle @trivikr
timers: named anonymous functions
482b662 
PR-URL: #20397
Refs: #8913
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
@trivikr
Copy link
Member

trivikr commented May 3, 2018

Landed in 482b662

Congratulations @js-kyle on your first commit in Node.js core! 🎉 🎉 🎉

@trivikr trivikr closed this May 3, 2018
MylesBorins pushed a commit that referenced this pull request May 4, 2018
@js-kyle @MylesBorins
timers: named anonymous functions
a8ffbbe 
PR-URL: #20397
Refs: #8913
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 8, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 8, 2018
@js-kyle @MylesBorins
timers: named anonymous functions
e552158 
PR-URL: #20397
Refs: #8913
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@JungMinu JungMinu JungMinu approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@js-kyle @apapirovski @trivikr @benjamingr @lpinca @TimothyGu @JungMinu @BridgeAR @nodejs-github-bot