Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps,lib,src: remove dependency on --allow-natives-syntax #20719

Closed
wants to merge 2 commits into from
Closed

deps,lib,src: remove dependency on --allow-natives-syntax #20719

wants to merge 2 commits into from

Commits on May 18, 2018

  1. deps: cherry-pick ff0a9793334 from upstream V8 

    Original commit message:

    [api] Expose PreviewEntries as public API

    Turn `debug::EntriesPreview` into a public API.
    This is a straightforward approach to addressing
    nodejs#20409
    (not relying on functionality behind `--allow-natives-syntax`)
    in Node.js.

Refs: v8/v8@ff0a979
    @addaleax
    addaleax committed May 18, 2018
    Configuration menu
    Copy the full SHA
    0babe5a View commit details
    Browse the repository at this point in the history

  2. lib,src: use V8 API for collection inspection 

    Use a new public V8 API for inspecting weak collections and
collection iterators, rather than using V8-internal functions
to achieve this. This currently comes with a slight modification of
the output for inspecting iterators generated by `Set().entries()`.

Fixes: nodejs#20409
    @addaleax
    addaleax committed May 18, 2018
    Configuration menu
    Copy the full SHA
    1d660fe View commit details
    Browse the repository at this point in the history