doc: improve specificity in CODEOWNERS #20729
Conversation
nodejs-github-bot
added
the
meta
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
Trott
added
fast-track
|
It is interesting why |
@vsemozhetbyt The last entry that matches has precedence and is the only one used. We probably want to re-order our CODEOWNERS file carefully. |
It also means we may want to reduce the number of entries in CODEOWNERS. |
That's true but I don't think this PR will fix it alone. According to the documentation, those teams cannot be cc'd for review because they do not have write access to the repository. |
|
@Trott same here, also needs a rebase before landing. |
Update CODEOWNERS entry for README.md to only apply to the top level README.md. For example, if test/common/README.md is updated, that should not be assigned to TSC automatically.
|
@apapirovski Rebased. |
|
Landed in 67463ad |
Update CODEOWNERS entry for README.md to only apply to the top level README.md. For example, if test/common/README.md is updated, that should not be assigned to TSC automatically. PR-URL: nodejs#20729 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Update CODEOWNERS entry for README.md to only apply to the top level README.md. For example, if test/common/README.md is updated, that should not be assigned to TSC automatically. PR-URL: #20729 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Update CODEOWNERS entry for README.md to only apply to the top level
README.md. For example, if test/common/README.md is updated, that should
not be assigned to TSC automatically.
Ref: #20717 (comment)
@richardlau
Checklist