Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: always use prefix=/ for tar-headers #2082

Closed
wants to merge 0 commits into from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jun 30, 2015

defaults to /usr/local otherwise which isn't helpful for node-gyp, nor standard assumptions about how headers files should be formatted

discovered this fault in our nightly headers tarballs

/R=@nodejs/build

@rvagg
Copy link
Member Author

rvagg commented Jun 30, 2015

I'll also land this on master at the same time, the interim fix is to add PREFIX=/ to make as in the latest next-nightly: https://jenkins-iojs.nodesource.com/job/iojs+release/nodes=osx1010-release-pkg/42/console

@bnoordhuis
Copy link
Member

LGTM but can you use capitalization and punctuation in the body of the commit log?

I don't understand the 'how headers files should be formatted' comment. Did you mean s/formatted/installed/?

@jbergstroem
Copy link
Member

I'm not a big fan about the inconsistency between the installs, but I fail to see when users will call this. Also, this (in my mind) is a temporary step even if it lives for a year.

LGTM

@mscdex mscdex added the build Issues and PRs related to build files or the CI. label Jun 30, 2015
@rvagg
Copy link
Member Author

rvagg commented Jul 4, 2015

@bnoordhuis thanks for proofing the commit msg as always, very appreciated. PTAL, current one is:

Defaults to /usr/local otherwise, which isn't helpful for node-gyp,
nor standard assumptions about how header directories should be
structured.

Does that make more sense?

rvagg added a commit that referenced this pull request Jul 15, 2015
Defaults to /usr/local otherwise, which isn't helpful for node-gyp,
nor standard assumptions about how header directories should be
structured.

PR-URL: #2082
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
@rvagg rvagg closed this Jul 15, 2015
@rvagg rvagg deleted the fix-headers-prefix branch July 15, 2015 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants