Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark tests as flaky as intermediate step #20835

Closed
wants to merge 2 commits into from

Conversation

BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented May 19, 2018

We have a few http2 issues that are currently resolved. Until they
are just mark these two tests as flaky.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 19, 2018
@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label May 19, 2018
@BridgeAR
Copy link
Member Author

This is a alternative to #20834 and #20832

We have a few http2 issues that are currently resolved. Until they
are, just mark these two tests as flaky.
Copy link
Member

@apapirovski apapirovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM.

@BridgeAR
Copy link
Member Author

BridgeAR commented May 19, 2018

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 19, 2018
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 19, 2018
@addaleax
Copy link
Member

#20750 also mentions parallel/test-http2-client-upload.

I’d still prefer the partial revert from #20834 over marking that test as flaky, tbh.

@BridgeAR
Copy link
Member Author

@addaleax this way the test itself does not have to be touched though and the code can be fixed. I personally believe that the status is somewhat meant for cases like the current one where in case we do not want a full revert.

@apapirovski
Copy link
Member

I prefer this since the tests will still fail instead of just being green but won't make the CI red.

@gireeshpunathil
Copy link
Member

frequent CI failures due to flaky tests have been an issue off late - causes confusion to the PR at hand, needing to re-run leading to additional time and effort. Marking flaky until they are fixed is a good idea.

@BridgeAR
Copy link
Member Author

@addaleax are you OK with this instead of #20834?

@addaleax
Copy link
Member

@BridgeAR Feel free to land it, yes

@BridgeAR
Copy link
Member Author

Landed in 8254e38

@BridgeAR BridgeAR closed this May 19, 2018
BridgeAR added a commit to BridgeAR/node that referenced this pull request May 19, 2018
We have a few http2 issues that are currently resolved. Until they
are, just mark these two tests as flaky.

PR-URL: nodejs#20835
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 22, 2018
We have a few http2 issues that are currently resolved. Until they
are, just mark these two tests as flaky.

PR-URL: #20835
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@addaleax addaleax mentioned this pull request May 22, 2018
@BridgeAR BridgeAR deleted the mark-tests-flaky branch January 20, 2020 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants