Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix fs.promises sample codes. #20838

Closed
wants to merge 2 commits into from
Closed

doc: fix fs.promises sample codes. #20838

wants to merge 2 commits into from

Conversation

kakts
Copy link
Contributor

@kakts kakts commented May 19, 2018

Summary

Recreated the same PR from #20805

Fix fs.promises sample codes in doc/api/fs.md .

Please review this.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels May 19, 2018
benjamingr
benjamingr approved these changes May 19, 2018
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this! Changes LGTM

@benjamingr
Copy link
Member

CI Lite: https://ci.nodejs.org/job/node-test-pull-request-lite/732/console

ghost
ghost reviewed May 19, 2018
View reviewed changes
doc/api/fs.md Outdated
@@ -3788,7 +3798,7 @@ If the third argument is a number, then it specifies `flags`, as shown in the
following example.

```js
const fs = require('fs');
const fsPromises = require('fs').promises;
const { COPYFILE_EXCL } = fs.constants;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fs is undefined

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. 726be35

vsemozhetbyt
vsemozhetbyt approved these changes May 19, 2018
View reviewed changes
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @Ehstrali's comment addressed.
Thank you!

@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label May 19, 2018
@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/734/

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 20, 2018
@vsemozhetbyt
Copy link
Contributor

Landed in 7295d3b
Thank you!

vsemozhetbyt pushed a commit that referenced this pull request May 20, 2018
@kakts @vsemozhetbyt
doc: fix fs.promises sample codes
7295d3b 
PR-URL: #20838
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 22, 2018
@kakts @MylesBorins
doc: fix fs.promises sample codes
8317a46 
PR-URL: #20838
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@addaleax addaleax mentioned this pull request May 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kakts @benjamingr @vsemozhetbyt @trivikr @nodejs-github-bot