Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: define SharedArrayBuffer as a known global #20849

Closed
wants to merge 1 commit into from
Closed

test: define SharedArrayBuffer as a known global #20849

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented May 20, 2018

This commit defines SharedArrayBuffer as a global for all tests, rather than adding comments to individual tests.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@cjihrig
test: define SharedArrayBuffer as a known global
5012771 
This commit defines SharedArrayBuffer as a global for all tests,
rather than adding comments to individual tests.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 20, 2018
@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label May 20, 2018
@BridgeAR
Copy link
Member

CI https://ci.nodejs.org/job/node-test-pull-request-lite/735/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 20, 2018
@addaleax
Copy link
Member

+1 to fast-tracking, to be explicit about it.

@addaleax
Copy link
Member

Landed in 680a171

@addaleax addaleax closed this May 21, 2018
addaleax pushed a commit that referenced this pull request May 21, 2018
@cjihrig @addaleax
test: define SharedArrayBuffer as a known global
680a171 
This commit defines SharedArrayBuffer as a global for all tests,
rather than adding comments to individual tests.

PR-URL: #20849
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@cjihrig cjihrig deleted the sab branch May 22, 2018 01:46
MylesBorins pushed a commit that referenced this pull request May 22, 2018
@cjihrig @MylesBorins
test: define SharedArrayBuffer as a known global
3afeaaa 
This commit defines SharedArrayBuffer as a global for all tests,
rather than adding comments to individual tests.

PR-URL: #20849
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@addaleax addaleax mentioned this pull request May 22, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 23, 2018
@cjihrig @MylesBorins
test: define SharedArrayBuffer as a known global
f5f9cdc 
This commit defines SharedArrayBuffer as a global for all tests,
rather than adding comments to individual tests.

PR-URL: #20849
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@benjamingr benjamingr benjamingr approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@tniessen tniessen tniessen approved these changes

@hiroppy hiroppy hiroppy approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@cjihrig @BridgeAR @addaleax @jasnell @benjamingr @TimothyGu @tniessen @hiroppy @nodejs-github-bot