Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: be specific about the unit of maxBuffer #209

Closed
wants to merge 1 commit into from

Conversation

timruffles
Copy link
Contributor

It's nice to be specific about units in docs.

@bnoordhuis
Copy link
Member

Please wrap lines at 80 columns. Apart from that, LGTM. If you update the PR, and maybe amend the commit log so it's not a one-liner, I'll land it.

@timruffles timruffles force-pushed the doc-max-buffer branch 2 times, most recently from be31479 to 5eb984f Compare December 29, 2014 19:03
the maxBuffer option was not self-documenting, so document
unit and its effect.
@timruffles
Copy link
Contributor Author

Done

bnoordhuis pushed a commit to bnoordhuis/io.js that referenced this pull request Dec 30, 2014
The maxBuffer option was not self-documenting, so document the unit and
its effect.

PR-URL: nodejs#209
Reviewed-By: Ben Noordhuis <[email protected]>
@bnoordhuis
Copy link
Member

Cheers Tim, landed in 6f49c24.

@bnoordhuis bnoordhuis closed this Dec 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants