Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "repl: add friendly tips about how to exit repl" #20972

Merged
merged 1 commit into from
May 28, 2018

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented May 26, 2018

This reverts commit 9aa4ec4.

This commit in question introduced a regression in repl.eval(),
as the context argument is no longer passed to runInContext().

Fixes: #20965

@nodejs-github-bot nodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label May 26, 2018
@cjihrig
Copy link
Contributor Author

cjihrig commented May 27, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/15109/

Failures appear unrelated

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 28, 2018
This reverts commit 9aa4ec4.

This commit in question introduced a regression in repl.eval(),
as the context argument is no longer passed to runInContext().

PR-URL: nodejs#20972
Fixes: nodejs#20965
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: John-David Dalton <[email protected]>
@cjihrig cjihrig merged commit 4dbfb09 into nodejs:master May 28, 2018
@cjihrig cjihrig deleted the revert branch May 28, 2018 17:54
MylesBorins pushed a commit that referenced this pull request May 29, 2018
This reverts commit 9aa4ec4.

This commit in question introduced a regression in repl.eval(),
as the context argument is no longer passed to runInContext().

PR-URL: #20972
Fixes: #20965
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: John-David Dalton <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants