Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: move upstream information to onboarding doc #21029

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 30, 2018

Move information about setting upstream remote and updating from
upstream out of onboarding-extras and into onboarding. Previously,
a link was provided in onboarding to the section. This puts all the
git setup information for Collaborator onboardings in one place.

Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 30, 2018
@Trott
Copy link
Member Author

Trott commented May 30, 2018

@vsemozhetbyt vsemozhetbyt added meta Issues and PRs related to the general management of the project. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 30, 2018
@apapirovski
Copy link
Member

@Trott sorry, this now needs rebase after the other change landed. Could you rebase? (Guessing you'll probably just land yourself at this point.)

Move information about setting `upstream` remote and updating from
`upstream` out of `onboarding-extras` and into `onboarding`. Previously,
a link was provided in `onboarding` to the section. This puts all the
git setup information for Collaborator onboardings in one place.
@Trott
Copy link
Member Author

Trott commented Jun 1, 2018

@Trott
Copy link
Member Author

Trott commented Jun 1, 2018

Landed in dce6d53

@Trott Trott closed this Jun 1, 2018
Trott added a commit to Trott/io.js that referenced this pull request Jun 1, 2018
Move information about setting `upstream` remote and updating from
`upstream` out of `onboarding-extras` and into `onboarding`. Previously,
a link was provided in `onboarding` to the section. This puts all the
git setup information for Collaborator onboardings in one place.

PR-URL: nodejs#21029
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 6, 2018
Move information about setting `upstream` remote and updating from
`upstream` out of `onboarding-extras` and into `onboarding`. Previously,
a link was provided in `onboarding` to the section. This puts all the
git setup information for Collaborator onboardings in one place.

PR-URL: #21029
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jun 6, 2018
@refack refack mentioned this pull request Oct 18, 2018
3 tasks
@Trott Trott deleted the keflavik-2 branch January 13, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants