Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

streams: make the pipeline callback mandatory #21054

Closed
wants to merge 2 commits into from
Closed

streams: make the pipeline callback mandatory #21054

wants to merge 2 commits into from

Commits on May 31, 2018

  1. streams: make the pipeline callback mandatory 

    Right now when not adding a callback to the pipeline it could cause
an uncaught exception if there is an error. Instead, just make the
callback mandatory as mostly done in all other Node.js callback APIs
so users explicitly have to decide what to do in such situations.
    @BridgeAR
    BridgeAR committed May 31, 2018
    Configuration menu
    Copy the full SHA
    e9a29f3 View commit details
    Browse the repository at this point in the history

  2. fixup

    @BridgeAR
    BridgeAR committed May 31, 2018
    Configuration menu
    Copy the full SHA
    3bd86d1 View commit details
    Browse the repository at this point in the history