build: use LC_ALL=en_US.UTF-8 in configure script #21221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
Trott
added
regression
2 tasks
Trott
changed the title
Trott
changed the title
On SmartOS 16, at least in our CI environment, LC_ALL cannot be set to en_US, so the configuration script fails. Use en_US.UTF-8 instead.
|
AIX failure is an unrelated known flaky. Re-run: https://ci.nodejs.org/job/node-test-commit-aix/15640/ |
|
Oddly, the linter lost connection with Jenkins or otherwise stalled. Re-run: https://ci.nodejs.org/job/node-test-linter/19862/ |
|
Same known-flaky failing on AIX. Looks like it's failed four times in a row and seems to be failing more than passing. That's unfortunate. Let's try AIX again: https://ci.nodejs.org/job/node-test-commit-aix/15644/ |
|
Closing in favor of #21222 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👍 to approve fast-tracking. This will (hopefully) unbreak CI.
On SmartOS 16, at least in our CI environment, LC_ALL cannot be set to
en_US, so the configuration script fails. Use en_US.UTF-8 instead.
Simpler alternative to #21220, but will have to run CI to see if it works everywhere.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes