Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: fix comment typos #21436

Closed
wants to merge 1 commit into from
Closed

Conversation

goto-bus-stop
Copy link
Contributor

When the deep(Strict)Equal comparison functions were moved to an
internal module, a variable named current was replaced with val1.
That accidentally also replaced a few "currently"s in comments.

Refs: #16084

Checklist

When the deep(Strict)Equal comparison functions were moved to an
internal module, a variable named `current` was replaced with `val1`.
That accidentally also replaced a few "currently"s in comments.

Refs: nodejs#16084
@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Jun 21, 2018
@danbev
Copy link
Contributor

danbev commented Jun 21, 2018

@BridgeAR BridgeAR added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jun 21, 2018
@lpinca
Copy link
Member

lpinca commented Jun 21, 2018

Add 👍 here if you approve fast-tracking.

@Trott
Copy link
Member

Trott commented Jun 21, 2018

@Trott
Copy link
Member

Trott commented Jun 21, 2018

FWIW, I'd be fine with removing "currently" entirely from all of these comments, but that's a total nit pick and I'm happy to see this land exactly as it is...uh...currently!

@Trott
Copy link
Member

Trott commented Jun 22, 2018

@targos
Copy link
Member

targos commented Jun 24, 2018

Landed in 686cb4d

@targos targos closed this Jun 24, 2018
targos pushed a commit that referenced this pull request Jun 24, 2018
When the deep(Strict)Equal comparison functions were moved to an
internal module, a variable named `current` was replaced with `val1`.
That accidentally also replaced a few "currently"s in comments.

Refs: #16084

PR-URL: #21436
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Jun 24, 2018
When the deep(Strict)Equal comparison functions were moved to an
internal module, a variable named `current` was replaced with `val1`.
That accidentally also replaced a few "currently"s in comments.

Refs: #16084

PR-URL: #21436
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Weijia Wang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. util Issues and PRs related to the built-in util module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.