Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test & util: Add a missing test and a conditonal teller #21455

Closed
wants to merge 1 commit into from
Closed

test & util: Add a missing test and a conditonal teller #21455

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 22, 2018 •
edited by ghost
Loading

  1. Add missing unit tests by ucs-2 in different kinds of cases.
  2. Add missing unit tests by usc-2 in different kinds of cases.
  3. Fix a bug：We cannot find ucs-2 in case 5's if condition after toLowerCase().
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Jun 22, 2018
@ghost ghost changed the title util: Remove useless formation indicator and add a missing unit test util: Add a missing unit test case with a type check Jun 22, 2018
@ghost ghost changed the title util: Add a missing unit test case with a type check util: Add a missing test with a template indicator removed Jun 22, 2018
@ghost ghost changed the title util: Add a missing test with a template indicator removed test: Add a missing test Jun 22, 2018
@ghost
Copy link
Author

ghost commented Jun 22, 2018

@mscdex：At last I abandoned re-writing after many tests about the efficiency but I changed the title and submit to add a missing test for utils. Plz have a review. Thanks anyway!

@apapirovski
Copy link
Member

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/893/

@Maledong you might want to associate your commit email with your account as otherwise you won't get proper credit for contributing to the project from Github.

@ghost ghost changed the title test: Add a missing test test & util: Add a missing test and a conditonal teller Jun 25, 2018
@ghost
Copy link
Author

ghost commented Jun 25, 2018 •
edited by ghost
Loading

OK, I've reset my accout with a new one verified by GitHub. And everything goes well with me.
@apapirovski ：I see this test failed in CI. Is there anything to be fixed with? Can I restart or make a new CI test? If OK, how?
Thks anyway

@apapirovski
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/15607/

@ghost
Copy link
Author

ghost commented Jun 25, 2018 •
edited by ghost
Loading

Thanks anyway!
Is there anything to change? I see that it can pass all the tests except for on mac……

test & util: Add missing tests and conditions
b287ae2 
1) Add missing unit tests by `ucs-2` in different kinds of cases.
2) Add missing unit tests by `usc-2` in different kinds of cases.
3) Fix a bug：We cannot find `ucs-2` in `case 5`'s `if` condition after
`toLowerCase()`
@joyeecheung
Copy link
Member

Jenkins failed to fetch the source code on macOS. Just to be safe, a new CI: https://ci.nodejs.org/job/node-test-pull-request/15632/

@ghost
Copy link
Author

ghost commented Jul 6, 2018

@joyeecheung & @apapirovski ：
Sorry to interrupt you both but I wanna say, since this has fixed a missing code conversion for ucs-2 and others, and this has passed all the tests, so just a reminder to merge them into your Node master if you can.
Thanks anyway!

@Trott
Copy link
Member

Trott commented Jul 8, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/15759/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 8, 2018
@Trott
Copy link
Member

Trott commented Jul 8, 2018

Adding author ready so this doesn't get missed again if it's ready to land. Whoever lands it will need to edit the commit message. (test & util -> test, util:).

@Trott
Copy link
Member

Trott commented Jul 8, 2018

Re-running Windows only: https://ci.nodejs.org/job/node-test-commit-windows-fanned/19156/

Trott pushed a commit to Trott/io.js that referenced this pull request Jul 8, 2018
@Trott
test,util: add missing tests and conditions
a478259 
1) Add missing unit tests by `ucs-2` in different kinds of cases.
2) Add missing unit tests by `usc-2` in different kinds of cases.
3) Fix a bug：We cannot find `ucs-2` in `case 5`'s `if` condition after
`toLowerCase()`

PR-URL: nodejs#21455
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@Trott
Copy link
Member

Trott commented Jul 8, 2018

Landed in a478259.

Thanks for the contribution! 🎉

@Trott Trott closed this Jul 8, 2018
@ghost ghost deleted the SimplifiedFornormalizeEncoding branch July 9, 2018 03:28
@ghost
Copy link
Author

ghost commented Jul 9, 2018

Thanks anyway.

targos pushed a commit that referenced this pull request Jul 10, 2018
@targos
test,util: add missing tests and conditions
dc84858 
1) Add missing unit tests by `ucs-2` in different kinds of cases.
2) Add missing unit tests by `usc-2` in different kinds of cases.
3) Fix a bug：We cannot find `ucs-2` in `case 5`'s `if` condition after
`toLowerCase()`

PR-URL: #21455
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Jul 17, 2018
Merged
This was referenced Jul 18, 2018
Closed
Closed
Closed
Closed
@beevelop beevelop mentioned this pull request Jul 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@apapirovski @joyeecheung @Trott @jasnell @trivikr @nodejs-github-bot