test: move net bytes-per-chunk test to sequential #21457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test is timing out on FreeBSD 10 in CI. It takes less than half as long to run when it is in sequential on that platform instead of parallel. Refs: nodejs#21322 (comment)
Trott
added
flaky-test
trivikr
approved these changes
Jun 22, 2018
Trott
added
the
author ready
|
CI is green. |
addaleax
approved these changes
Jun 22, 2018
cjihrig
approved these changes
Jun 22, 2018
This was referenced Jun 22, 2018
jasnell
approved these changes
Jun 22, 2018
|
Landed in 1ee4703 |
targos
pushed a commit
that referenced
this pull request
Jun 24, 2018
The test is timing out on FreeBSD 10 in CI. It takes less than half as long to run when it is in sequential on that platform instead of parallel. Refs: #21322 (comment) PR-URL: #21457 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 24, 2018
The test is timing out on FreeBSD 10 in CI. It takes less than half as long to run when it is in sequential on that platform instead of parallel. Refs: #21322 (comment) PR-URL: #21457 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is timing out on FreeBSD 10 in CI. It takes less than half as
long to run when it is in sequential on that platform instead of
parallel.
Refs: #21322 (comment)
Use 👍 reaction here to fast-track.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes