Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: correct crypto.randomFill() and randomFillSync() #21550

Closed
wants to merge 3 commits into from
Closed

doc: correct crypto.randomFill() and randomFillSync() #21550

wants to merge 3 commits into from

Commits on Jul 12, 2018

  1. doc: correct crypto.randomFill() and randomFillSync() 

    Correct return type of `crypto.randomFillSync()` which is of same type as
passed as `buffer` argument.

Correct samples for `randomFill()` and `randomFillSync()` using a `TypeArray`
or `DataView` as these types don't support `.toString(encoding)`.
    @Flarna
    Flarna committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    df0068d View commit details
    Browse the repository at this point in the history

  2. use .byteOffset and .byteLength to construct Buffer

    @Flarna
    Flarna committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    4305294 View commit details
    Browse the repository at this point in the history

  3. fix lint

    @Flarna
    Flarna committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    6395f98 View commit details
    Browse the repository at this point in the history