Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n-api: test uint32 truncation #21722

Closed
wants to merge 1 commit into from
Closed

n-api: test uint32 truncation #21722

wants to merge 1 commit into from

Conversation

gabrielschulhof
Copy link
Contributor

Re: nodejs/abi-stable-node#55 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@gabrielschulhof build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/231/pipeline

@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Jul 9, 2018
@gabrielschulhof gabrielschulhof mentioned this pull request Jul 9, 2018
Closed
mhdawson
mhdawson approved these changes Jul 9, 2018
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrielschulhof
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/15814/

@gabrielschulhof
Copy link
Contributor Author

CI resumed as: https://ci.nodejs.org/job/node-test-pull-request/15820/

gabrielschulhof pushed a commit that referenced this pull request Jul 12, 2018
n-api: test uint32 truncation
acf0606 
Re: nodejs/abi-stable-node#55 (comment)
PR-URL: #21722
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@gabrielschulhof
Copy link
Contributor Author

Landed in acf0606.

@gabrielschulhof gabrielschulhof deleted the n-api-test-uint32-truncation branch July 12, 2018 05:47
targos pushed a commit that referenced this pull request Jul 12, 2018
@targos
n-api: test uint32 truncation
4f3bbfa 
Re: nodejs/abi-stable-node#55 (comment)
PR-URL: #21722
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@targos targos mentioned this pull request Jul 17, 2018
Merged
This was referenced Jul 18, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gabrielschulhof @nodejs-github-bot @jasnell @addaleax @cjihrig @mhdawson