Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use V8 graph heap snapshot API #21741

Closed
wants to merge 6 commits into from
Closed

src: use V8 graph heap snapshot API #21741

wants to merge 6 commits into from

Commits on Jul 14, 2018

  1. src: add iteration over all base objects to Environment

    @addaleax
    addaleax committed Jul 14, 2018
    Configuration menu
    Copy the full SHA
    c16261f View commit details
    Browse the repository at this point in the history

  2. deps: cherry-pick 555c811 from upstream V8 

    Original commit message:

    [api] Switch from `SetBuildEmbedderGraphCallback` to `AddBuildEmbedderGraphCallback`

    `SetBuildEmbedderGraphCallback`, unlike `SetWrapperClassInfoProvider`,
    assumes a monolithic embedder that can provide all necessary information.
    That is not the case for e.g. Node.js, which can e.g. provide multiple Node.js
    instances per V8 Isolate, as well as native addons that may allocate resources
    on their own.

    Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
    Change-Id: Ib53dfde82416dd69934b08623e27d674a483ac2d
    Reviewed-on: https://chromium-review.googlesource.com/1082441
    Commit-Queue: Ulan Degenbaev <[email protected]>
    Reviewed-by: Ulan Degenbaev <[email protected]>
    Reviewed-by: Yang Guo <[email protected]>
    Cr-Commit-Position: refs/heads/master@{nodejs#53545}

Refs: v8/v8@555c811
    @addaleax
    addaleax committed Jul 14, 2018
    Configuration menu
    Copy the full SHA
    6d10570 View commit details
    Browse the repository at this point in the history

  3. fixup! deps: cherry-pick 555c811 from upstream V8

    @addaleax
    addaleax committed Jul 14, 2018
    Configuration menu
    Copy the full SHA
    f778d10 View commit details
    Browse the repository at this point in the history

  4. src: use V8 graph heap snapshot API 

    Transition to a newer, more flexible API for
heap snapshot creation.

This addresses a currently pending deprecation in the V8 API.

Fixes: nodejs#21633
    @addaleax
    addaleax committed Jul 14, 2018
    Configuration menu
    Copy the full SHA
    8e5489f View commit details
    Browse the repository at this point in the history

  5. src: make heap snapshot & embedder graph accessible for tests 

    Add methods that allow inspection of heap snapshots and a JS
version of our own embedder graph.

These can be used in tests and might also prove useful for
ad-hoc debugging. Usage requires `--expose-internals` and
prints a warning similar to our other modules whose primary
purpose is test support.
    @addaleax
    addaleax committed Jul 14, 2018
    Configuration menu
    Copy the full SHA
    0f2153f View commit details
    Browse the repository at this point in the history

  6. test: add heap snapshot tests 

    Add a number of tests that validate that heap snapshots
contain what we expect them to contain, and cross-check
against a JS version of our own embedder graphs.
    @addaleax
    addaleax committed Jul 14, 2018
    Configuration menu
    Copy the full SHA
    1050d97 View commit details
    Browse the repository at this point in the history