removes string 3rd arg from calls to assert.strictEqual() #21828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prevents AssertionError from reporting string literal, instead displays values of first 2 args passed to assert.strictEqual()
Trott
approved these changes
Jul 16, 2018
cjihrig
approved these changes
Jul 16, 2018
tniessen
approved these changes
Jul 16, 2018
trivikr
approved these changes
Jul 16, 2018
lpinca
approved these changes
Jul 17, 2018
jasnell
approved these changes
Jul 17, 2018
trivikr
pushed a commit
that referenced
this pull request
Jul 18, 2018
prevents AssertionError from reporting string literal, instead displays values of first 2 args passed to assert.strictEqual() PR-URL: #21828 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in cfe0c02 Congratulations @hectorcoronado for your first commit in Node.js core! 🎉🎉🎉 |
targos
pushed a commit
that referenced
this pull request
Jul 19, 2018
prevents AssertionError from reporting string literal, instead displays values of first 2 args passed to assert.strictEqual() PR-URL: #21828 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
This was referenced Aug 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prevents AssertionError from reporting string literal,
instead displays values of first 2 args passed to
assert.strictEqual() in /test/parallel/test-stream-transform-final-sync.js
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes