Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor cluster-net-listen-relative-path #21863

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 18, 2018

Refactor test-cluster-net-listen-relative-path:

  • Use arrow funcitons for callbacks.
  • Move skip-test code closer to start of file.
  • Use assert.ok() where appropriate.
  • Capitalize and punctuate comments.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Refactor test-cluster-net-listen-relative-path:

* Use arrow funcitons for callbacks.
* Move skip-test code closer to start of file.
* Use assert.ok() where appropriate.
* Capitalize and punctuate comments.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 18, 2018
@Trott
Copy link
Member Author

Trott commented Jul 18, 2018

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 18, 2018
Trott added a commit to Trott/io.js that referenced this pull request Jul 20, 2018
Refactor test-cluster-net-listen-relative-path:

* Use arrow funcitons for callbacks.
* Move skip-test code closer to start of file.
* Use assert.ok() where appropriate.
* Capitalize and punctuate comments.

PR-URL: nodejs#21863
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott
Copy link
Member Author

Trott commented Jul 20, 2018

Landed in c3f8dd6

@Trott Trott closed this Jul 20, 2018
targos pushed a commit that referenced this pull request Jul 20, 2018
Refactor test-cluster-net-listen-relative-path:

* Use arrow funcitons for callbacks.
* Move skip-test code closer to start of file.
* Use assert.ok() where appropriate.
* Capitalize and punctuate comments.

PR-URL: #21863
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Jul 31, 2018
@Trott Trott deleted the fixit-fixit branch January 13, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants