Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove redundant Makefile target #21915

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 20, 2018

The only target that uses the
tools/doc/node_modules/js-yaml/package.json target is doc-only. As a
result of a recent change, it has tools/doc/node_modules as a
prerequisite, which does the exact same npm install as
tools/doc/node_modules/js-yaml/package.json. Remove
tools/doc/node_modules/js-yaml/package.json as unnecessary.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

The only target that uses the
`tools/doc/node_modules/js-yaml/package.json` target is `doc-only`. As a
result of a recent change, it has `tools/doc/node_modules` as a
prerequisite, which does the exact same npm install as
`tools/doc/node_modules/js-yaml/package.json`. Remove
`tools/doc/node_modules/js-yaml/package.json` as unnecessary.
@Trott
Copy link
Member Author

Trott commented Jul 20, 2018

(There doesn't appear to be an analogous rule in vcbuild.bat, but someone correct me if I'm wrong about that.)

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 20, 2018
@Trott
Copy link
Member Author

Trott commented Jul 20, 2018

Please 👍 this comment to fast-track.

@Trott
Copy link
Member Author

Trott commented Jul 20, 2018

@nodejs/build-files

@Trott
Copy link
Member Author

Trott commented Jul 20, 2018

@rubys

@Trott
Copy link
Member Author

Trott commented Jul 20, 2018

@Trott
Copy link
Member Author

Trott commented Jul 23, 2018

Landed in b38b8d3

@Trott Trott closed this Jul 23, 2018
Trott added a commit to Trott/io.js that referenced this pull request Jul 23, 2018
The only target that uses the
`tools/doc/node_modules/js-yaml/package.json` target is `doc-only`. As a
result of a recent change, it has `tools/doc/node_modules` as a
prerequisite, which does the exact same npm install as
`tools/doc/node_modules/js-yaml/package.json`. Remove
`tools/doc/node_modules/js-yaml/package.json` as unnecessary.

PR-URL: nodejs#21915
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Jul 24, 2018
The only target that uses the
`tools/doc/node_modules/js-yaml/package.json` target is `doc-only`. As a
result of a recent change, it has `tools/doc/node_modules` as a
prerequisite, which does the exact same npm install as
`tools/doc/node_modules/js-yaml/package.json`. Remove
`tools/doc/node_modules/js-yaml/package.json` as unnecessary.

PR-URL: #21915
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Jul 31, 2018
@Trott Trott deleted the remove-redundant branch January 13, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants