Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspector: fixed V8InspectorClient::currentTimeMS method #21917

Closed
wants to merge 1 commit into from
Closed

inspector: fixed V8InspectorClient::currentTimeMS method #21917

wants to merge 1 commit into from

Conversation

alexkozy
Copy link
Member

On inspector side inside V8 we assume that this method should
return number of ms since epoch. It is important for different inspector parts,
e.g. timestamp of reported console messages.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

On inspector side inside V8 we assume that this method should
return number of ms since epoch.
@alexkozy alexkozy requested a review from eugeneo July 21, 2018 08:01
Copy link
Contributor

@maclover7 maclover7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@maclover7
Copy link
Contributor

@maclover7 maclover7 added inspector Issues and PRs related to the V8 inspector protocol author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jul 22, 2018
alexkozy added a commit that referenced this pull request Aug 2, 2018
On inspector side inside V8 we assume that this method should
return number of ms since epoch.

PR-URL: #21917
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
@alexkozy
Copy link
Member Author

alexkozy commented Aug 2, 2018

Landed in 0ed164e

@alexkozy alexkozy closed this Aug 2, 2018
@alexkozy alexkozy deleted the provide-correct-current-time branch August 2, 2018 05:06
targos pushed a commit that referenced this pull request Aug 2, 2018
On inspector side inside V8 we assume that this method should
return number of ms since epoch.

PR-URL: #21917
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants