Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BUILDING.md #22067

Closed
wants to merge 1 commit into from
Closed

Update BUILDING.md #22067

wants to merge 1 commit into from

Conversation

brandonlwt
Copy link
Contributor

Grammatical error corrected.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • [x ] documentation is changed or added
  • commit message follows commit guidelines

Grammatical error corrected.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Aug 1, 2018
@addaleax
Copy link
Member

addaleax commented Aug 1, 2018

CI: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/395/pipeline

Collaborators, please feel free to 👍 this comment to approve fast-tracking.

@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 1, 2018
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@brandonlwt
Copy link
Contributor Author

Good day, may I know when will it be merged?
Your kind consideration is highly appreciated.
Thank you.

@addaleax
Copy link
Member

addaleax commented Aug 1, 2018

@brandonlwt Fast-tracking means that it can be merged as soon as all automated checks are green.

… Which they are now, so:

Landed in 05b3176 🎉 Congratulations and thanks for the pull request!

@addaleax addaleax closed this Aug 1, 2018
addaleax pushed a commit that referenced this pull request Aug 1, 2018
Grammatical error corrected.

PR-URL: #22067
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@brandonlwt
Copy link
Contributor Author

Oh! Thank you for the explanation! Highly appreciated!
vielen Dank!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants