deps: cherry-pick 6ee8345 from upstream V8

[joyeecheung]

Original commit message:

[heap-profiler] Allow embedder to specify edge names

This patch adds a variant of EmbedderGraph::AddEdge() which
allows the embedder to specify the name of an edge. The edges
added without name are element edges with auto-incremented indexes
while the edges added with names will be internal edges with
the specified names for more meaningful output in the heap
snapshot.

Refs: https://github.com/nodejs/node/pull/21741
Bug: v8:7938
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: I8feefa2cf6911743e24b3b2024e0e849b0c65cd3
Reviewed-on: https://chromium-review.googlesource.com/1133299
Commit-Queue: Ulan Degenbaev <[email protected]>
Reviewed-by: Ulan Degenbaev <[email protected]>
Cr-Commit-Position: refs/heads/master@{#54412}

Refs: v8/v8@6ee8345

cc @addaleax

[nodejs-github-bot]

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/413/pipeline

[joyeecheung]

CI: https://ci.nodejs.org/job/node-test-pull-request/16168/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1567/

[targos]

Why don't land on v10?

[joyeecheung]

@targos Because this is ABI-breaking.

This patch needs additional tweaking in src/heap_utils.cc to compile, I'm working on a fix

[joyeecheung]

CI: https://ci.nodejs.org/job/node-test-pull-request/16175/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1569/

[joyeecheung]

CI is green. Can you take a look at the new commit? Thanks! @addaleax

[addaleax]

Nice, thanks!

[joyeecheung]

Uh, wait, I was working on naming edges on top of this PR and noticed that there was a bug in test/common/heap.js so the graph has not been actually validated (if (expectedNode.edges) should've been if (expectedNode.children)), which hide another bug in this PR (edge_info had not been pushed to the edges array - the entries were still the edge targets)

I've fixed the bugs, PTAL, thanks! @addaleax @jasnell

CI: https://ci.nodejs.org/job/node-test-pull-request/16185/

[joyeecheung]

Ping @addaleax @jasnell Can you take a look at the last commit? Thanks!

[joyeecheung]

Ping again: @addaleax @jasnell

[joyeecheung]

CI: https://ci.nodejs.org/job/node-test-pull-request/16305/

[joyeecheung]

New CI: https://ci.nodejs.org/job/node-test-pull-request/16330/

[joyeecheung]

CI: https://ci.nodejs.org/job/node-test-pull-request/16369/

[joyeecheung]

CI: https://ci.nodejs.org/job/node-test-pull-request/16422/

[joyeecheung]

CI: https://ci.nodejs.org/job/node-test-pull-request/16517/

[joyeecheung]

One unrelated failure. Resume build: https://ci.nodejs.org/job/node-test-pull-request/16522/

Failures in job https://ci.nodejs.org/job/node-test-pull-request/16517/

rhel72-s390x

See failures on test-linuxonecc-rhel72-s390x-3:

not ok 1957 parallel/test-trace-events-fs-sync
  ---
  duration_ms: 2.641
  severity: fail
  exitcode: 1
  stack: |-
    assert.js:84
      throw new AssertionError(obj);
      ^
    
    AssertionError [ERR_ASSERTION]: fs.sync.open:
    { status: null,
      signal: 'SIGSEGV',
      output: [ null, '', '' ],
      pid: 29496,
      stdout: '',
      stderr: '' }
        at Object.<anonymous> (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/parallel/test-trace-events-fs-sync.js:139:10)
        at Module._compile (internal/modules/cjs/loader.js:689:30)
        at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
        at Module.load (internal/modules/cjs/loader.js:599:32)
        at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
        at Function.Module._load (internal/modules/cjs/loader.js:530:3)
        at Function.Module.runMain (internal/modules/cjs/loader.js:742:12)
        at startup (internal/bootstrap/node.js:257:19)
        at bootstrapNodeJSCore (internal/bootstrap/node.js:628:3)
  ...

[joyeecheung]

CI is green