Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Replace util.debug with console.error #2214

Closed
wants to merge 1 commit into from
Closed

doc: Replace util.debug with console.error #2214

wants to merge 1 commit into from

Conversation

yosuke-furukawa
Copy link
Member

I found util.debug in our API document.
util.debug is deprecated, according to here

@mscdex mscdex added the doc Issues and PRs related to the documentations. label Jul 21, 2015
@thefourtheye
Copy link
Contributor

Strictly speaking, util.debug includes the string DEBUG: and can print only one value at a time. So, console.error is not a drop-in replacement for util.debug. But, as we already issue deprecation notice for util.debug, this PR LGTM.

@Fishrock123
Copy link
Contributor

I'd prefer to replace it for .log(), it isn't always an error here. :)

@thefourtheye
Copy link
Contributor

@Fishrock123 Oh yeah, log is better here :-)

@yosuke-furukawa
Copy link
Member Author

I fixed this! PTAL @Fishrock123 @thefourtheye

@Fishrock123
Copy link
Contributor

LGTM

@@ -718,7 +718,7 @@ argument will be populated. The following example checks if the file
`/etc/passwd` can be read and written by the current process.

fs.access('/etc/passwd', fs.R_OK | fs.W_OK, function(err) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function (err)

@thefourtheye
Copy link
Contributor

LGTM minus nits

yosuke-furukawa added a commit that referenced this pull request Jul 23, 2015
PR-URL: #2214
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@yosuke-furukawa
Copy link
Member Author

landed 4ef2b5f
Thank you for your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants