Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: don't mask descriptor.enumerable #22172

Closed
wants to merge 1 commit into from
Closed

test: don't mask descriptor.enumerable #22172

wants to merge 1 commit into from

Conversation

tomleah
Copy link
Contributor

@tomleah tomleah commented Aug 7, 2018

From NodeTodo //cc @Trott

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 7, 2018
@Trott
Copy link
Member

Trott commented Aug 8, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16269/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 8, 2018
@Trott
Copy link
Member

Trott commented Aug 9, 2018

Resume Build: https://ci.nodejs.org/job/node-test-pull-request/16306/

@Trott
Copy link
Member

Trott commented Aug 9, 2018

Closer. Resume Build: https://ci.nodejs.org/job/node-test-pull-request/16308/

Trott pushed a commit to Trott/io.js that referenced this pull request Aug 9, 2018
@tomleah @Trott
test: don't mask descriptor.enumerable
2fd71f9 
PR-URL: nodejs#22172
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
@Trott
Copy link
Member

Trott commented Aug 9, 2018

Landed in 2fd71f9.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Aug 9, 2018
targos pushed a commit that referenced this pull request Aug 11, 2018
@tomleah @targos
test: don't mask descriptor.enumerable
95b2467 
PR-URL: #22172
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
@tomleah tomleah deleted the remove-arg branch August 13, 2018 08:25
@rvagg rvagg mentioned this pull request Aug 13, 2018
Merged
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 16, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@fesebuv fesebuv fesebuv approved these changes

@maclover7 maclover7 maclover7 approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@gdams gdams gdams approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.