Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: replace _WG_ with _team_ #22183

Closed
wants to merge 1 commit into from
Closed

doc: replace _WG_ with _team_ #22183

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 7, 2018

AFAICT, there is no N-API Working Group. There is an N-API team, but
AFAIK there is no charter etc. (And if I'm wrong and there is, then
https://nodejs.org/en/about/working-groups/ needs an update!)

Checklist

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 7, 2018
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 7, 2018
@Trott
Copy link
Member Author

Trott commented Aug 8, 2018

Re-running lite job now that #22184 has landed.

@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 8, 2018
AFAICT, there is no N-API Working Group. There *is* an N-API team, but
AFAIK there is no charter etc. (And if I'm wrong and there is, then
https://nodejs.org/en/about/working-groups/ needs an update!)
@Trott
Copy link
Member Author

Trott commented Aug 8, 2018

Hmmm...it appears that the lite-pipeline job may not rebase against master. So it's not picking up the recently-landed fix. Guess I'll rebase and force push and see if that helps things along...

@Trott
Copy link
Member Author

Trott commented Aug 8, 2018

@nodejs/tsc @nodejs/n-api

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Aug 8, 2018
AFAICT, there is no N-API Working Group. There *is* an N-API team, but
AFAIK there is no charter etc. (And if I'm wrong and there is, then
https://nodejs.org/en/about/working-groups/ needs an update!)

PR-URL: nodejs#22183
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott
Copy link
Member Author

Trott commented Aug 8, 2018

Landed in fcb46a4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants