Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove second arg from assert.ifError() #22190

Closed
wants to merge 1 commit into from

Conversation

mhamwala
Copy link
Contributor

@mhamwala mhamwala commented Aug 8, 2018

test/parallel/test-fs-readfile.js has a call to assert.ifError() that receives two arguments.
There is no second argument used in assert.ifError(). This PR removes this argument.

This fix was recommended by @Trott via NodeTodo.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

`test/parallel/test-fs-readfile.js` has a call to `assert.ifError()` that receives two arguments.
There is no second argument used in `assert.ifError()`. This PR removes this argument.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 8, 2018
@gdams
Copy link
Member

gdams commented Aug 8, 2018

@maclover7 maclover7 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 8, 2018
@Trott
Copy link
Member

Trott commented Aug 9, 2018

jasnell pushed a commit that referenced this pull request Aug 10, 2018
`test/parallel/test-fs-readfile.js` has a call to
`assert.ifError()` that receives two arguments.

There is no second argument used in `assert.ifError()`.
This PR removes this argument.

PR-URL: #22190
Reviewed-By: George Adams <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Aug 10, 2018

Landed in dcfd323!

@jasnell jasnell closed this Aug 10, 2018
@Trott
Copy link
Member

Trott commented Aug 10, 2018

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

targos pushed a commit that referenced this pull request Aug 11, 2018
`test/parallel/test-fs-readfile.js` has a call to
`assert.ifError()` that receives two arguments.

There is no second argument used in `assert.ifError()`.
This PR removes this argument.

PR-URL: #22190
Reviewed-By: George Adams <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.